Skip to content

[RHCLOUD-48734] Add traditional expandable row support to DataViewTable#681

Open
katarinazaprazna wants to merge 1 commit into
patternfly:mainfrom
katarinazaprazna:add-support-for-traditional-expandable-rows
Open

[RHCLOUD-48734] Add traditional expandable row support to DataViewTable#681
katarinazaprazna wants to merge 1 commit into
patternfly:mainfrom
katarinazaprazna:add-support-for-traditional-expandable-rows

Conversation

@katarinazaprazna

Copy link
Copy Markdown

Summary

  • Add support for traditional expandable rows
  • Traditional expand renders a dedicated toggle column as the first column
  • No breaking API changes: columnId on ExpandableContent changed from required to optional, existing consumers with columnId get identical compound behavior
  • Add examples and documentation for both expand types
Screenshot From 2026-07-09 23-53-01

Test plan

  • npm run test passes (11 tests in DataViewTableBasic)
  • Docs dev server: expandable rows example renders with toggle column
  • Docs dev server: compound expandable rows example renders unchanged
  • Traditional expand: rows without content show empty toggle cell

Closes RHCLOUD-48734

Assisted-by: Claude Code

@MariSvirik

Copy link
Copy Markdown

To be consistent with a simple expandable row pattern from PF,

  1. remove grey background and
  2. Change the orientation of the caret according to the new PF update (default facing down, opened facing up)
  3. Follow this behaviour for the caret https://www.patternfly.org/components/table/react-demos/expandcollapse-all/ - grey background at the click and the hover
  4. It would be great if you could add support for "Expand all" (caret in the column header section)

More technical issues consult with Patternfly team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants